Remove tokens from lex compat #3883
Merged
+64
−121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kddnewton
force-pushed
the
remove-tokens
branch
from
9805ffe to
983fb5a
Compare
Instead of having custom classes, use arrays and track which tokens we should ignore the state for in the test.
kddnewton
force-pushed
the
remove-tokens
branch
from
983fb5a to
a333b56
Compare
Member
|
From #3868 (comment) I guess? One downside is then probably more of the upstream Ripper tests may fail, due to not ignoring the state during comparisons (for tests outside the prism repo). I think it's probably fine though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having custom classes, use arrays and track which tokens we should ignore the state for in the test.